Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update sign in sign up, integrating with database #112

Merged
merged 6 commits into from
Sep 11, 2024

Conversation

almeiphi
Copy link
Contributor

@almeiphi almeiphi commented Aug 8, 2024

Resolves #110

Description

  • Update sign up and sign in integrating with database
  • Refactor error handling to use constants for error messages
  • Fix signup error message when user already exists in database

Definition of Done

  • Acceptance Criteria is fulfilled
  • Changes and issues encountered are documented
  • Github issue is linked in this PR

Copy link

github-actions bot commented Aug 8, 2024

Test Results

87 tests   80 ✅  2m 4s ⏱️
17 suites   7 💤
 3 files     0 ❌

Results for commit f361568.

♻️ This comment has been updated with latest results.

@almeiphi almeiphi merged commit 4241f35 into main Sep 11, 2024
3 checks passed
@almeiphi almeiphi deleted the feature/110-sign-up-sign-in-bff branch September 11, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web app sign up / sign in integrated with bff and persist in user database
2 participants