Skip to content

Commit

Permalink
Merge pull request #77 from digipost/nytt-felt-pickupnotice
Browse files Browse the repository at this point in the history
Nytt felt på PickupNotice: extraInformation
  • Loading branch information
martin-jackson authored Apr 9, 2024
2 parents b253b01 + beb9e3f commit c601907
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 2 deletions.
1 change: 1 addition & 0 deletions datatypes-examples.xml
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,7 @@
<cod-amount>0</cod-amount>
<cod-fee>0</cod-fee>
</cost>
<extra-information>Krever fremvisning av Pass eller Norsk nasjonalt ID-kort (Show Passport or Norwegian national ID-card). Fullmakt ikke tillatt.</extra-information>
<status>READY_FOR_PICKUP</status>
<tags>POSTEN</tags>
<language>NB</language>
Expand Down
1 change: 1 addition & 0 deletions datatypes.xsd
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,7 @@
<xs:element name="pickup-place" type="tns:pickupPlace"/>
<xs:element minOccurs="0" name="package" type="tns:package"/>
<xs:element minOccurs="0" name="cost" type="tns:cost"/>
<xs:element minOccurs="0" name="extra-information" type="xs:string"/>
<xs:element minOccurs="0" name="status" type="tns:status"/>
<xs:element maxOccurs="unbounded" minOccurs="0" name="tags" type="tns:tag"/>
<xs:element default="NB" minOccurs="0" name="language" type="tns:language"/>
Expand Down
4 changes: 3 additions & 1 deletion readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -490,9 +490,10 @@ Details about a pickup notice
|pickupPlace|[PickupPlace](#pickupnoticepickupplace)|yes|where the parcel can be fetched|
|thePackage|[Package](#pickupnoticepackage)|no|package information|
|cost|[Cost](#pickupnoticecost)|no|Information about value, mva, customs processing and more|
|extraInformation|String|no|Additional information about the pickup. May for example be used to inform the recipient that identification will be required upon pickup.|
|status|[Status](#pickupnoticestatus)|no|The state the package is at present time|
|tags|Set|no|Tags to describe the document|
|language|[Language](#pickupnoticelanguage)|no|Languange for the document|
|language|[Language](#pickupnoticelanguage)|no|Language for the document|
|link|[ExternalLink](#pickupnoticeexternallink)|no|An optional link to an external site, where the recipient can perform additional actions for their package|

### PickupNotice.Barcode
Expand Down Expand Up @@ -652,6 +653,7 @@ Valid values:
<cod-amount>0</cod-amount>
<cod-fee>0</cod-fee>
</cost>
<extra-information>Krever fremvisning av Pass eller Norsk nasjonalt ID-kort (Show Passport or Norwegian national ID-card). Fullmakt ikke tillatt.</extra-information>
<status>READY_FOR_PICKUP</status>
<tags>POSTEN</tags>
<language>NB</language>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,10 @@ public class PickupNotice implements DataType {
@XmlElement(name = "cost")
@Description("Information about value, mva, customs processing and more")
Cost cost;

@XmlElement(name = "extra-information")
@Description("Additional information about the pickup. May for example be used to inform the recipient that identification will be required upon pickup.")
String extraInformation;

@XmlElement(name = "status")
@Description("The state the package is at present time")
Expand All @@ -93,7 +97,7 @@ public class PickupNotice implements DataType {
Set<Tag> tags;

@XmlElement(defaultValue = "NB")
@Description("Languange for the document")
@Description("Language for the document")
Language language;

@XmlElement(name = "link")
Expand Down Expand Up @@ -122,6 +126,7 @@ public PickupNotice withDefaultsForMissingOptionalValues() {
, PickupPlace.EXAMPLE
, Package.EXAMPLE
, Cost.EXAMPLE
, "Krever fremvisning av Pass eller Norsk nasjonalt ID-kort (Show Passport or Norwegian national ID-card). Fullmakt ikke tillatt."
, Status.READY_FOR_PICKUP
, Collections.singleton(Tag.POSTEN)
, Language.NB
Expand Down

0 comments on commit c601907

Please sign in to comment.