Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update InvoicePayment with new fields #74

Closed
wants to merge 5 commits into from
Closed

Update InvoicePayment with new fields #74

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
36b4f02
Update InvoicePayment with required field paymentScheduledDate and op…
NghiNg Dec 28, 2023
aebac2c
Update new field referenceNumber to be remittanceInformation, and pay…
NghiNg Jan 3, 2024
95fad2f
Update new field paymentScheduledDate type to LocalDate
NghiNg Jan 3, 2024
31b84ea
Remove required and @NotNull on optional fields
NghiNg Jan 4, 2024
9255eda
Add LocalDateXmlAdapter.java
NghiNg Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,15 +419,17 @@ Payment information for an invoice

### Fields

|Name|Type|Required|Description|
|----|----|--------|-----------|
|paymentId|String|yes|Unique id to reference the payment with third party|
|paymentStatus|String|yes|A status a given payment is in. ISO20022 payment statuses can be used|
|paymentTime|ZonedDateTime|yes|When the payment is done|
|debtorAccount|String|yes|The debtor account for the payment. Exactly 11 digits|
|debtorAccountName|String|no|Optional name of the account|
|paymentChannel|String|yes|Name the third party performing the payment|
|paymentBank|[Bank](#invoicepaymentbank)|yes|The bank payment is registered with|
| Name |Type| Required | Description |
|-----------------------|----|----------|-----------------------------------------------------------------------------|
| paymentId |String| yes | Unique id to reference the payment with third party |
| paymentStatus |String| yes | A status a given payment is in. ISO20022 payment statuses can be used |
| paymentTime |ZonedDateTime| yes | When the payment is done |
| debtorAccount |String| yes | The debtor account for the payment. Exactly 11 digits |
| debtorAccountName |String| no | Optional name of the account |
| paymentChannel |String| yes | Name the third party performing the payment |
| paymentBank |[Bank](#invoicepaymentbank)| yes | The bank payment is registered with |
| paymentScheduledDate |ZonedDateTime| no | When the payment is scheduled to be paid |
| remittanceInformation |String| no | Optional reference number user inputted when invoice was missing KID number |

### InvoicePayment.Bank

Expand Down
10 changes: 10 additions & 0 deletions src/main/java/no/digipost/api/datatypes/types/invoice/InvoicePayment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,14 @@ public class InvoicePayment implements DataType {
@NotNull
Bank paymentBank;

@XmlElement(required = true, name = "payment-scheduled-date")
@Description("The date the payment is scheduled for")
ZonedDateTime paymentScheduledDate;
NghiNg marked this conversation as resolved.
Show resolved Hide resolved

@XmlElement(name = "remittance-information")
@Description("The reference-number user has entered when paying the invoice for missing KID")
String referenceNumber;

public static final InvoicePayment EXAMPLE = new InvoicePayment(
"33aa4572ac1c61d807345c5968ab1fbd"
, "PDNG"
Expand All @@ -63,5 +71,7 @@ public class InvoicePayment implements DataType {
, null
, "My pay app"
, Bank.EXAMPLE
, ZonedDateTime.of(2020, 10, 1, 0, 0, 0, 0, ZoneId.of("+01:00"))
, "123123123"
);
}