Legg til en limit for sårbarhetsvarsling på slack #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eks. kun varsle ved CRITICAL sårbarheter.
| @@ -48,6 +49,7 @@ suspend fun main(): Unit = coroutineScope { | |||
| } | |||
| } | |||
|
|
|||
| val severityLimitForNotifications = if (System.getenv().containsKey("severity_limit")) SecurityAdvisorySeverity.safeValueOf(System.getenv("severity_limit")) else SecurityAdvisorySeverity.CRITICAL | |||
There was a problem hiding this comment.
Kanskje defaulten burde vere mindre alvorlig enn CRITICAL. Kanskje alle? Det er den tryggaste defaulten på eit vis.
There was a problem hiding this comment.
Hmm, forresten, vi snakket vel om at dette skulle være opt-in? Er det det p.t.? 🤔
There was a problem hiding this comment.
Typ slack_notification_of_new_vulns.enabled, med default false. Så kan det brukes as is av andre uten å sette opp Slack-integrasjon.
There was a problem hiding this comment.
Hvis du ikke har gitt webhook-url til slack, så er ikke varsling til slack satt opp. Tenkte det ga mening, så vi slipper å håndtere caset med notifications.enabled = true og webhook-url undefined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.