Re-instantiate GithubApiClient regularly #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our application typically crashes after some time (>1 day) when running in production, similarly to what we experienced with the ApolloClient some time ago. We hope that re-instantiating the client will solvee this issue. If not, we will have to do some form of try-catch within the coroutines, for instance resulting in a reboot.
hermanwh
force-pushed
the
solve-client-crashing
branch
from
ca1d19b to
09e7314
Compare
draperunner
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our application typically crashes after some time (>1 day) when running in production, similarly to what we experienced with the ApolloClient some time ago. We hope that re-instantiating the client will solvee this issue. If not, we will have to do some form of try-catch within the coroutines, for instance resulting in a reboot.