Add optional dependency on com.sun.xml.bind:jaxb-impl

It seems that phive-xml need an implementation of jaxb to parse schema-files.
digipost · Aug 14, 2024 · 2447367 · 2447367
1 parent de13126
commit 2447367
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 10 deletions.
diff --git a/api/pom.xml b/api/pom.xml
@@ -29,6 +29,13 @@
             <groupId>org.eaxy</groupId>
             <artifactId>eaxy</artifactId>
         </dependency>
+        <dependency>
+            <groupId>com.sun.xml.bind</groupId>
+            <artifactId>jaxb-impl</artifactId>
+            <version>4.0.5</version>
+            <scope>runtime</scope>
+            <optional>true</optional>
+        </dependency>
 
         <dependency>
             <groupId>org.junit.jupiter</groupId>

diff --git a/api/src/test/java/peppol/bis/invoice3/domain/ExampleUsage1.java b/api/src/test/java/peppol/bis/invoice3/domain/ExampleUsage1.java
@@ -333,14 +333,6 @@ public static Invoice example1(){
                     .withFinancialInstitutionBranch(new FinancialInstitutionBranch("NDEANOKK"))
             );
 
-        final PaymentMeans paymentMeans2 = new PaymentMeans(
-            new PaymentMeansCode("30")
-        ).withPaymentID("123456789101")
-            .withPayeeFinancialAccount(
-                new PayeeFinancialAccount("60650514745")
-                    .withFinancialInstitutionBranch(new FinancialInstitutionBranch("NDEANOKK"))
-            );
-
         final Invoice invoice = new Invoice(
             "12345678910"
             , "2020-11-19"
@@ -354,8 +346,7 @@ public static Invoice example1(){
             .withDueDate("2020-11-30")
             .withPaymentTerms(new PaymentTerms("10 dager"))
             .withDelivery(delivery)
-            .withPaymentMeans(paymentMeans1)
-            .withPaymentMeans(paymentMeans2);
+            .withPaymentMeans(paymentMeans1);
 
         final PeppolBillingApi<Invoice> api = PeppolBillingApi.create(invoice);