-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy daml script #20646
Remove legacy daml script #20646
Conversation
run-all-tests: true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use an ifdef here and keep it running in 2.1
|
||
The Daml Script library defines the API used to implement Daml scripts. See :doc:`/daml-script/index`:: for more information on Daml script. | ||
NOTE: This is the unstable Daml 3 script library replacement. It can and will make breaking changes without warning up to the release of Daml 3.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same with line below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed on a call - LGTM modulo comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves #20639
8bafdb8:
daml3-script
anddaml-script-lts
as simplydaml-script
, with respective warningsScript
monad (since the package name has been changed)Script execution failed on commit at <somewhere>
have been loosened. To be fixed in a later commit and test changes reverted.b22abff:
daml3-script
withdaml-script
project wide3d32a86:
37a616d:
b603bb8:
f135c2c:
263dc4e:
if=
to diagnostic expectations so they can be gated by defsef1de7a:
58819c3:
d04c037:
TODO: