Add missing write barrier in IOU_initialize #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byroot
force-pushed
the
missing-write-barrier
branch
from
817768f to
889154f
Compare
|
Sorry, could you rebase the PR off main? I seem to have botched it :-. |
Since it's the initialize method, it's extremely unlikely that `self` would have reached the old generation, hence almost impossible to run into this bug short of using `GC.stress`. But still, that write barrier is technically needed.
byroot
force-pushed
the
missing-write-barrier
branch
from
9b6aacc to
e5ea69f
Compare
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it's the initialize method, it's extremely unlikely that
selfwould have reached the old generation, hence almost impossible to run into this bug short of usingGC.stress.But still, that write barrier is technically needed.