split fixtures for test_cancel_translation from test_data.json #3380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MizukiTemma @JoeyStk I don't actually want to merge this, but the could demonstrate how to load test fixtures in the future. As far as I can tell this works as intended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Demonstration on splitting test fixtures. As this test and the corresponding test data is already merged in develop, I would not change it now. This PR is more a demonstration or suggestion on how to handle future test data in order to avoid adjusting unrelated tests.
Proposed changes
Side effects
Resolved issues
Fixes: #3360
Pull Request Review Guidelines