Add function to pass libmicrohttpd options when starting Prometheus listener #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the same as promhttp_start_daemon(), except that it exposes MHD_start_daemon()'s variadic options, to allow applications to pass flags directly into libmicrohttpd. The use case for this functionality is to allow the metrics listener to be bound to a specific socket address (instead of binding to a given port on the wildcard address) using MHD_OPTION_SOCK_ADDR, etc.
|
I think this is a great addition. I also need it! |
|
#79 enables a different approach: calling libmicrohttpd directly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new function,
promhttp_start_daemon_with_options(), which exposes the variadic options interface ofMHD_start_daemon()to applications using prometheus-client-c. This would allow applications to e.g. bind to a specific IP address instead of the wildcard address, which is the libmicrohttpd default.