Encode WriteMultipleRegistersRequest using values length
#102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Encode the "Byte Count" field of a WriteMultipleRegistersRequest using the length of the `values` bytes rather than multiplying `quantity` by 2. This allows the request to be used with non-standard Modbus implementations e.g. those that use 32-bit registers instead of the standard 16-bit registers.
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encode the "Byte Count" field of a WriteMultipleRegistersRequest using the length of the
valuesbytes rather than multiplyingquantityby 2.This allows the request to be used with non-standard Modbus implementations e.g. those that use 32-bit registers instead of the standard 16-bit registers.