Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile without -std=c++11, not really needed #353

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pekdon
Copy link

@pekdon pekdon commented Feb 7, 2025

Might be a bit unconventional, downgrading the required standard, but without these extra , and the use of isinf this compiles and runs on Solaris 10 still which seems like a good fit for Dillo.

@rodarima
Copy link
Member

rodarima commented Feb 7, 2025

Thanks, the C++11 check is to prevent accidentally adding a dependency with newer standards.

We can run it only on the CI, as Dillo can be built with a compiler that supports C++03 and GNU macros, but I need to be sure it works first by making it fail.

compiles and runs on Solaris 10 still which seems like a good fit for Dillo.

Screenshot for the gallery? https://dillo-browser.github.io/gallery/

@pekdon
Copy link
Author

pekdon commented Feb 7, 2025

Sounds reasonable to have such a check, easy to accidentally add!

Something like that?
dillo_solaris10_cde

@sevan
Copy link

sevan commented Feb 8, 2025

This is great, and a huge timesaver. Alongside this patch I also had to make similar changes to
dw/fltkui.cc, src/css.hh, src/cssparser.cc, src/dillo.cc, src/html_common.hh, src/xembed.cc and then I could build Dillo 3.2.0 on OS X 10.4 with GCC 4.0.1 on my PowerBook which takes just over 2 minutes. With a C++11 dependency add another 24 hours :)
additional patch

Tested with GCC 4.0.1 & 8.5 on OS X 10.4 PowerPC.

sevan added a commit to sevan/teabrew that referenced this pull request Feb 8, 2025
Enable webp support
Enable IPv6 support by default.
Remove the C++11 dependency so that GCC 4.0 can be used via dillo-browser/dillo#353
_POSIX_C_SOURCE guards different sections on 10.4 to 10.5 & up.
--disable-debug is unrecognised.
sevan added a commit to mistydemeo/tigerbrew that referenced this pull request Feb 8, 2025
Enable webp support
Enable IPv6 support by default.
Remove the C++11 dependency so that GCC 4.0 can be used via dillo-browser/dillo#353
_POSIX_C_SOURCE guards different sections on 10.4 to 10.5 & up.
--disable-debug is unrecognised.
Might be a bit unconventional, downgrading the required standard, but
without these extra , and the use of isinf this compiles and runs on
Solaris 10 still which seems like a good fit for Dillo.

Additional fixes for non C++11 in here too courtesy Sevan Janiyan,
making Dillo compile and run on OS X 10.4 PowerPC with GCC 4.0.1 & 8.5.
@pekdon
Copy link
Author

pekdon commented Feb 9, 2025

Updated my branch based on your changes too @sevan (mentioned in the commit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants