Incorrect narrow_phase collisions after using ColliderSet::set_parent #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vrixyz
commented
Nov 6, 2024
Vrixyz
force-pushed
the
734-reparent_bug_in_narrow_phase
branch
from
04bb2e1 to
41feb21
Compare
Vrixyz
commented
Dec 16, 2024
…be should be removed from graph_indices too?
…missing parent change
sebcrozet
force-pushed
the
734-reparent_bug_in_narrow_phase
branch
from
b00e486 to
7388fdf
Compare
sebcrozet
approved these changes
Feb 2, 2025
There was a problem hiding this comment.
Looks good, thanks! I took the liberty of making the following changes:
- Removed debug print statements.
- Changed the test a bit to test two consecutive reparenting.
- Don’t rewove the pairs from the graph upon reparenting. I believe this isn’t needed because the collision information will be automatically cleared by the contact/intersection update function if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 2 tests: 1 for each scenario.