Modularize schema #24
Conversation
...use links to raw files in branch as reference for testing.
(somebody will have to fix it properly later)
|
I only took a quick look at the editor but from what I saw it seems to be running as expected: https://skohub.io/editor/?schema=https://raw.githubusercontent.com/dini-ag-kim/lrmi-profile/23-modularize/draft/schemas/schema.json |
There was a problem hiding this comment.
I suggest few changes in context-schema.json, the language part does not work as expected (master has this problem as well I noticed).
I tried with the suggested changes in my fork and then publishing theoretically works, but I get an error from skohub saying it can't find the respective inbox. Which is strange, because the items shows up in the inbox. But this seems to be another topic, have to open an issue for this.
| "type": "object", | ||
| "properties": { | ||
| "@language": { | ||
| "$ref": "https://raw.githubusercontent.com/dini-ag-kim/lrmi-profile/23-modularize/draft/schemas/Language.json" |
There was a problem hiding this comment.
This does not seem to work as expected. There is no field added to select the language for @context.
When trying to publish something, it throws an error because we have "minItems": 2, but the field for language selection for "@context" does not show up in the editor.
I recommend setting "minItems": 1 and required to an empty array for now till this is fixed
| }, | ||
| "additionalProperties": false, | ||
| "required": [ | ||
| "@language" |
There was a problem hiding this comment.
as mentioned above I suggest setting this to []
| "title": "JSON-LD Context", | ||
| "description": "The JSON-LD context for the structured resource descriptions", | ||
| "type": "array", | ||
| "minItems": 2, |
There was a problem hiding this comment.
as mentioned below I suggest setting this to 1
See skohub-io/skohub-editor#32 for this.
I assume you are talking about publishing a description to a I suggest to discuss SKoHub Pubsub related issues at https://github.com/hbz/skohub-pubsub/issues. Please open an issue over there including a link to an inbox you have set up. |
|
with #25 this will work. |
I did a first quick run at the modularization and made some dirty changes to the test script so that it will run. @sroertgen please take a look at it whether it goes in the right direction.