Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the demo build.gradle, so it now correctly skips signingconfig where necessary #299

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

InnoLuke
Copy link

mobile/build.gradle provides a signingConfig for release builds. The data for the signingConfig was loaded from local.properties, if it existed, otherwise the signingConfig was skipped. The problem is that Android Studio auto-creates a local.properties, so the file always exists when gradle runs - even if you manually delete it.

The local.properties exists check is therefore useless, and results in failed builds when checking out the project locally, or running on Jitpack: Cause: path may not be null or empty string. path=''

This PR removes the useless exists check and replaces it with a check that all the necessary properties are present (non-null) before passing them to signingConfig.

I also cleaned up some duplicated plugin declarations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant