Fix the demo build.gradle, so it now correctly skips signingconfig where necessary #299
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mobile/build.gradle provides a signingConfig for release builds. The data for the signingConfig was loaded from
local.properties
, if it existed, otherwise the signingConfig was skipped. The problem is that Android Studio auto-creates alocal.properties
, so the file always exists when gradle runs - even if you manually delete it.The local.properties
exists
check is therefore useless, and results in failed builds when checking out the project locally, or running on Jitpack:Cause: path may not be null or empty string. path=''
This PR removes the useless
exists
check and replaces it with a check that all the necessary properties are present (non-null) before passing them to signingConfig.I also cleaned up some duplicated plugin declarations.