Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src/problem and src/optim organization improvements #229

Merged
merged 6 commits into from
Jun 9, 2023
Merged

src/problem and src/optim organization improvements #229

merged 6 commits into from
Jun 9, 2023

Conversation

adrienbanse
Copy link
Collaborator

  • Abstract type for problems
  • 1 Optimizer = 1 module
  • All the abstraction-based methods are now implemented in the super-module Abstraction
  • All solvers have "NotImplementedError"-like errors if wrong problem is given to them

@adrienbanse adrienbanse requested a review from JulienCalbert June 8, 2023 14:58
@adrienbanse
Copy link
Collaborator Author

@JulienCalbert I'll re-open this PR when #228 is merged, so that I can change the solve the conflicts in the docs examples

@adrienbanse adrienbanse closed this Jun 8, 2023
@adrienbanse adrienbanse reopened this Jun 9, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2023 •
edited
Loading

Codecov Report

Merging #229 (e12aa0b) into master (5b30746) will increase coverage by 0.00%.
The diff coverage is 2.35%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #229   +/-   ##
=======================================
  Coverage   41.91%   41.91%           
=======================================
  Files          58       61    +3     
  Lines        4423     4430    +7     
=======================================
+ Hits         1854     1857    +3     
- Misses       2569     2573    +4
Impacted Files Coverage Δ
src/optim/abstraction/SCOTS_abstraction.jl 0.00% <0.00%> (ø)
src/optim/abstraction/ellipsoids_abstraction.jl 0.00% <0.00%> (ø)
...c/optim/abstraction/lazy_ellipsoids_abstraction.jl 0.00% <0.00%> (ø)
src/optim/optim.jl 100.00% <ø> (ø)
src/problem/problem.jl 66.66% <50.00%> (ø)
src/optim/branch_and_bound.jl 91.30% <66.66%> (-0.47%) ⬇️
src/optim/abstraction/abstraction.jl 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

JulienCalbert
JulienCalbert reviewed Jun 9, 2023
View reviewed changes
docs/src/examples/State-feedback Abstraction PWA System.jl Outdated
@@ -97,13 +98,14 @@ X_origin = SVector(0.0, 0.0);
X_step = SVector(1.0/n_step, 1.0/n_step);
P = (1/n_x)*diagm((X_step./2).^(-2))

state_grid = DO.GridEllipsoidalRectangular(X_origin, X_step, P, rectX)
state_grid = DO.Grid
soidalRectangular(X_origin, X_step, P, rectX)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the error is here

@adrienbanse adrienbanse merged commit 1f61a0e into master Jun 9, 2023
@JulienCalbert JulienCalbert deleted the clean_problem_optim_adrien branch February 18, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulienCalbert JulienCalbert JulienCalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adrienbanse @codecov-commenter @JulienCalbert