Skip to content

Commit

Permalink
Merge pull request #28 from dipeshdulal/chore/struct-embedding-logger
Browse files Browse the repository at this point in the history
Chore: Added struct embedding for logger.
  • Loading branch information
dipeshhkc authored Aug 5, 2021
2 parents 7067231 + 5e18561 commit 33fe960
Show file tree
Hide file tree
Showing 12 changed files with 30 additions and 33 deletions.
4 changes: 2 additions & 2 deletions api/controllers/jwt_auth_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ func NewJWTAuthController(

// SignIn signs in user
func (jwt JWTAuthController) SignIn(c *gin.Context) {
jwt.logger.Zap.Info("SignIn route called")
jwt.logger.Info("SignIn route called")
// Currently not checking for username and password
// Can add the logic later if necessary.
user, _ := jwt.userService.GetOneUser(uint(1))
Expand All @@ -41,7 +41,7 @@ func (jwt JWTAuthController) SignIn(c *gin.Context) {

// Register registers user
func (jwt JWTAuthController) Register(c *gin.Context) {
jwt.logger.Zap.Info("Register route called")
jwt.logger.Info("Register route called")
c.JSON(200, gin.H{
"message": "register route",
})
Expand Down
14 changes: 7 additions & 7 deletions api/controllers/user_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ func (u UserController) GetOneUser(c *gin.Context) {

id, err := strconv.Atoi(paramID)
if err != nil {
u.logger.Zap.Error(err)
u.logger.Error(err)
c.JSON(http.StatusBadRequest, gin.H{
"error": err,
})
Expand All @@ -41,7 +41,7 @@ func (u UserController) GetOneUser(c *gin.Context) {
user, err := u.service.GetOneUser(uint(id))

if err != nil {
u.logger.Zap.Error(err)
u.logger.Error(err)
c.JSON(http.StatusInternalServerError, gin.H{
"error": err.Error(),
})
Expand All @@ -58,7 +58,7 @@ func (u UserController) GetOneUser(c *gin.Context) {
func (u UserController) GetUser(c *gin.Context) {
users, err := u.service.GetAllUser()
if err != nil {
u.logger.Zap.Error(err)
u.logger.Error(err)
}
c.JSON(200, gin.H{"data": users})
}
Expand All @@ -69,15 +69,15 @@ func (u UserController) SaveUser(c *gin.Context) {
trxHandle := c.MustGet(constants.DBTransaction).(*gorm.DB)

if err := c.ShouldBindJSON(&user); err != nil {
u.logger.Zap.Error(err)
u.logger.Error(err)
c.JSON(http.StatusInternalServerError, gin.H{
"error": err.Error(),
})
return
}

if err := u.service.WithTrx(trxHandle).CreateUser(user); err != nil {
u.logger.Zap.Error(err)
u.logger.Error(err)
c.JSON(http.StatusInternalServerError, gin.H{
"error": err.Error(),
})
Expand All @@ -98,15 +98,15 @@ func (u UserController) DeleteUser(c *gin.Context) {

id, err := strconv.Atoi(paramID)
if err != nil {
u.logger.Zap.Error(err)
u.logger.Error(err)
c.JSON(http.StatusBadRequest, gin.H{
"error": err,
})
return
}

if err := u.service.DeleteUser(uint(id)); err != nil {
u.logger.Zap.Error(err)
u.logger.Error(err)
c.JSON(http.StatusInternalServerError, gin.H{
"error": err.Error(),
})
Expand Down
2 changes: 1 addition & 1 deletion api/middlewares/cors.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ func NewCorsMiddleware(handler lib.RequestHandler, logger lib.Logger, env lib.En

// Setup sets up cors middleware
func (m CorsMiddleware) Setup() {
m.logger.Zap.Info("Setting up cors middleware")
m.logger.Info("Setting up cors middleware")

debug := m.env.Environment == "development"
m.handler.Gin.Use(cors.New(cors.Options{
Expand Down
10 changes: 5 additions & 5 deletions api/middlewares/db_trx.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,11 @@ func NewDatabaseTrx(

// Setup sets up database transaction middleware
func (m DatabaseTrx) Setup() {
m.logger.Zap.Info("setting up database transaction middleware")
m.logger.Info("setting up database transaction middleware")

m.handler.Gin.Use(func(c *gin.Context) {
txHandle := m.db.DB.Begin()
m.logger.Zap.Info("beginning database transaction")
m.logger.Info("beginning database transaction")

defer func() {
if r := recover(); r != nil {
Expand All @@ -57,15 +57,15 @@ func (m DatabaseTrx) Setup() {

// rollback transaction on server errors
if c.Writer.Status() == http.StatusInternalServerError {
m.logger.Zap.Info("rolling back transaction due to status code: 500")
m.logger.Info("rolling back transaction due to status code: 500")
txHandle.Rollback()
}

// commit transaction on success status
if statusInList(c.Writer.Status(), []int{http.StatusOK, http.StatusCreated}) {
m.logger.Zap.Info("committing transactions")
m.logger.Info("committing transactions")
if err := txHandle.Commit().Error; err != nil {
m.logger.Zap.Error("trx commit error: ", err)
m.logger.Error("trx commit error: ", err)
}
}
})
Expand Down
2 changes: 1 addition & 1 deletion api/middlewares/jwt_auth.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ func (m JWTAuthMiddleware) Handler() gin.HandlerFunc {
c.JSON(http.StatusInternalServerError, gin.H{
"error": err.Error(),
})
m.logger.Zap.Error(err)
m.logger.Error(err)
c.Abort()
return
}
Expand Down
2 changes: 1 addition & 1 deletion api/routes/auth.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ type AuthRoutes struct {

// Setup user routes
func (s AuthRoutes) Setup() {
s.logger.Zap.Info("Setting up routes")
s.logger.Info("Setting up routes")
auth := s.handler.Gin.Group("/auth")
{
auth.POST("/login", s.authController.SignIn)
Expand Down
2 changes: 1 addition & 1 deletion api/routes/user.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ type UserRoutes struct {

// Setup user routes
func (s UserRoutes) Setup() {
s.logger.Zap.Info("Setting up routes")
s.logger.Info("Setting up routes")
api := s.handler.Gin.Group("/api").Use(s.authMiddleware.Handler())
{
api.GET("/user", s.userController.GetUser)
Expand Down
10 changes: 5 additions & 5 deletions bootstrap/bootstrap.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,10 @@ func bootstrap(

lifecycle.Append(fx.Hook{
OnStart: func(context.Context) error {
logger.Zap.Info("Starting Application")
logger.Zap.Info("---------------------")
logger.Zap.Info("------- CLEAN -------")
logger.Zap.Info("---------------------")
logger.Info("Starting Application")
logger.Info("---------------------")
logger.Info("------- CLEAN -------")
logger.Info("---------------------")

conn.SetMaxOpenConns(10)
go func() {
Expand All @@ -50,7 +50,7 @@ func bootstrap(
return nil
},
OnStop: func(context.Context) error {
logger.Zap.Info("Stopping Application")
logger.Info("Stopping Application")
conn.Close()
return nil
},
Expand Down
6 changes: 3 additions & 3 deletions lib/db.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,11 @@ func NewDatabase(env Env, zapLogger Logger) Database {
})

if err != nil {
zapLogger.Zap.Info("Url: ", url)
zapLogger.Zap.Panic(err)
zapLogger.Info("Url: ", url)
zapLogger.Panic(err)
}

zapLogger.Zap.Info("Database connection established")
zapLogger.Info("Database connection established")

return Database{
DB: db,
Expand Down
7 changes: 2 additions & 5 deletions lib/logger.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (

// Logger structure
type Logger struct {
Zap *zap.SugaredLogger
*zap.SugaredLogger
}

// NewLogger sets up logger
Expand All @@ -27,8 +27,5 @@ func NewLogger(env Env) Logger {

sugar := logger.Sugar()

return Logger{
Zap: sugar,
}

return Logger{sugar}
}
2 changes: 1 addition & 1 deletion repository/user_repository.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ func NewUserRepository(db lib.Database, logger lib.Logger) UserRepository {
// WithTrx enables repository with transaction
func (r UserRepository) WithTrx(trxHandle *gorm.DB) UserRepository {
if trxHandle == nil {
r.logger.Zap.Error("Transaction Database not found in gin context. ")
r.logger.Error("Transaction Database not found in gin context. ")
return r
}
r.Database.DB = trxHandle
Expand Down
2 changes: 1 addition & 1 deletion services/jwt_auth_service.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ func (s JWTAuthService) CreateToken(user models.User) string {
tokenString, err := token.SignedString([]byte(s.env.JWTSecret))

if err != nil {
s.logger.Zap.Error("JWT validation failed: ", err)
s.logger.Error("JWT validation failed: ", err)
}

return tokenString
Expand Down

0 comments on commit 33fe960

Please sign in to comment.