Merge pull request #189 from diprism/inf_eigenvalue

Make check for infinite eigenvalues more reliable
diprism · Sep 13, 2024 · 670eda4 · 670eda4
2 parents 0752fa1 + 7b6544f
commit 670eda4
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/fggs/semirings.py b/fggs/semirings.py
@@ -155,10 +155,11 @@ def solve_thunks(self,
         a = make_a()
         b = make_b()
         try:
-            a.neg_().diagonal().add_(1)
-            x = torch.linalg.solve(a, b)
-            if torch.all(torch.copysign(torch.tensor(1.), x) > 0.): # catches -0.0
-                return x
+            if not torch.any(torch.isinf(a)):
+                a.neg_().diagonal().add_(1)
+                x = torch.linalg.solve(a, b)
+                if torch.all(x >= 0.):
+                    return x
         except RuntimeError as e:
             if '(Cannot allocate memory)' in str(e): raise
             pass