Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add namespace template variable #186

Merged
merged 4 commits into from
Jan 5, 2025
Merged

Conversation

fgeck
Copy link
Contributor

@fgeck fgeck commented Jan 4, 2025

Description of the change

Added namespaceOverride template variable to support flexible namespace configurations.
Introduced helper function in helpers.tpl for namespace resolution.
Updated relevant templates to utilize the new namespace logic.
Bumped Helm chart version to 2.21.2.

Benefits

A user can deploy the uptime-kuma helm chart in a configured namesapce when deploying.

Possible drawbacks

None that come to mind.

Applicable issues

N/A

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the README.md

@fgeck fgeck requested a review from dirsigler as a code owner January 4, 2025 18:54
@fgeck
Copy link
Contributor Author

fgeck commented Jan 5, 2025

Lint and test issues seem not related to my changes:

Version 3.7 was not found in the local cache
Error: The version '3.7' with architecture 'x64' was not found for Ubuntu 24.04.
The list of all available versions can be found here: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json

@dirsigler
Copy link
Owner

Updated some version and pushed into main.
Please rebase from main, it should work afterwards.

@fgeck
Copy link
Contributor Author

fgeck commented Jan 5, 2025

@dirsigler just did a merge via github ui instead of a rebase, hope it is fine when you do a squash merge when merging into main branch.

@dirsigler dirsigler merged commit d71fa8b into dirsigler:main Jan 5, 2025
6 checks passed
@fgeck fgeck deleted the fork-main branch January 5, 2025 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants