Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E Tests failing due to js errors on the campaign page. #852

Open
2 tasks
jtfairbank opened this issue Nov 20, 2022 · 6 comments
Open
2 tasks

E2E Tests failing due to js errors on the campaign page. #852

jtfairbank opened this issue Nov 20, 2022 · 6 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jtfairbank
Copy link
Contributor

jtfairbank commented Nov 20, 2022

  • Find the loop on the /src/pages/donate/... page which doesn't set the key prop on it's children, and set the key prop to resolve the JS error.
  • Run the End to End tests to see if this resolves the issue with them.

image

Originally posted by @coderbyheart in #840 (comment)

@jtfairbank jtfairbank added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Nov 20, 2022
@rudychung
Copy link

Hi! Could I give this one a try?

@coderbyheart
Copy link
Member

Sure!

@rudychung
Copy link

rudychung commented Nov 20, 2022

When I open a fundraiser page, I can't seem to replicate the warning message. Can you give me any pointers?

image
Only one I seem to get is this, but I think it might be different.

@coderbyheart
Copy link
Member

I see three errors here: https://distributeaid.org/donate/

image

@rudychung
Copy link

I see three errors here: https://distributeaid.org/donate/

image

Those errors seem to all be related to hydration. It was the list child unique key prop warnings which I was trying to replicate locally, which I think only show up in the dev environment.

@coderbyheart
Copy link
Member

These errors are from the live site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants