Contributions from Taylor's Review of giving-tuesday-2022

[jtfairbank]

Relates to #699

[ghost]

👇 Click on the image for a new way to code review

• Make big changes easier — review code in small groups of related files

• Know where to start — see the whole change at a glance

• Take a code tour — explore the change with an interactive tour

• Make comments and review — all fully sync’ed with github

  Try it now!

Legend

[coderbyheart]

comment: I see targets are back. I think this is contra-productive providing targets without the explanation where this target comes from. None of the fundraisers have this explained in their texts. I also think this is not helpful for open-ended projects, which all of them are. In practice they can have unlimited funding needs. So if this is not tied to clear milestones I advise against providing targets.

[jtfairbank]

@coderbyheart it's tricky. After talking to Sara & Ellie they really wanted to set this up with donations going to each fundraiser, since they are organizing donors / aid matching around each fundraiser.

You're absolutely right that most if not all these fundraisers are ongoing, and have ongoing needs (or we'd know what to do with $XX,XXX more than the target). For giving Tuesday, they want to focus on an achievable amount across all fundraisers for the 1-day push, so our initial targets will be for 1 month of expenses for each fundraiser. However, we've repeatedly seen that framing things in terms of "what this covers for DA" doesn't do nearly as well as "what impact this creates". So Ellie is going to come up with a key monthly stat per fundraiser to highlight the impact that achieving each target would create, along with a suggested donation amount to tie the individual donation to some portion of the overall impact ($20 lets us meet X need, etc).

In the future, I think it'd make sense to define "milestones" for each fundraiser. This could describe what the funding is expected to go towards, paired with a description of the outcomes it'd lead to (X aid shipped, Y capability added, etc). That'd also provide a nice history and make reporting easy.

What do you think about this approach? Move forward with individual fundraiser links + targets for now, then build in milestones within / between fundraisers?

[coderbyheart]

Yes, I think milestones are really the best way to document needs. This could be modeled similar to the allocations, so a project can have multiple of those.

[jtfairbank]

Hey @coderbyheart ended up converting most of the css to tailwind. Is this last main.donate style needed?

[jtfairbank]

Hey @coderbyheart this is ready for your review! Bit of time pressure to get the initial donate pages launched so we can start lining up matching donations for Giving Tuesday + use the links when prepping marketing / social media. So it'd be helpful to get two types of feedback: "need to change now" vs. "can launch but update this over the next week before Giving Tuesday".

[coderbyheart]

There are a bunch of errors when the dev server is started:

warn Dropping content block type="block-image-with-caption", since it is not implemented yet.
warn Dropping empty section: #0
warn Dropping unknown content block: type="block-card"
warn Dropping unknown content block: type="block-card"
warn Dropping unknown content block: type="block-card"
warn Dropping empty section: #1

 ERROR 

Page title="Connecting Communities" is empty after processing.

[coderbyheart]

e2e tests don't pass but I guess you want to fix that later.

[coderbyheart]

Most likely caused by JS errors on campaign page:

[jtfairbank]

@coderbyheart yeah I definitely want to do a testing pass on the donate / fundraising page code. Probably after this week tho if it's stable enough to make it thru giving tuesday.

The gatsby build is logging a lot of content errors / warnings to let us know what to expect out of the final build. I think many of these will go away once we implement other content blocks (image, youtube, etc). We should def look into a better way to report content issues tho, would it be possible to log them during gatsby build and dump the log file to a slack channel or something? Basically, if there is a content issue how can we let our content contributors know without a dev having to catch it in the build logs.

Made an issue for the bug you pointed out: #852 (comment)

[jtfairbank]

Really great working with you on this one!

[coderbyheart]

would it be possible to log them during gatsby build and dump the log file to a slack channel or something?

It would be possible but logging without actions is just noise and distraction. Nobody will be able to distinguish which ones are new and which ones can be ignored.