Update test vector files #1153
Merged
Update test vector files #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjpatton
approved these changes
Dec 10, 2024
| @@ -2391,25 +2406,37 @@ mod tests { | |||
| #[ignore] | |||
| #[test] | |||
| fn test_vec_poplar1_0() { | |||
| check_test_vec(include_str!("test_vec/08/Poplar1_0.json")); | |||
| check_test_vec(include_str!("test_vec/13/Poplar1_0.json")); | |||
There was a problem hiding this comment.
FWIW we ended up dropping the version number from the path in the spec repo: https://github.com/cfrg/draft-irtf-cfrg-vdaf/tree/main/test_vec/vdaf
It might help make updating easier if we mirror the directory structure there. Though TBH I think it's fine as is.
divergentdave
force-pushed
the
david/update-test-vector-files
branch
from
c336a8e to
c608dc8
Compare
inahga
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the test vector files and makes some preparatory changes to related tests. This includes the new files from cfrg/draft-irtf-cfrg-vdaf#526.