mastic: Add encoding for prep state #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjpatton
force-pushed
the
cjpatton/947-7-prep-state-serialization
branch
from
176bf27 to
5449de6
Compare
cjpatton
force-pushed
the
cjpatton/947-6-more-test-vec
branch
from
5ac4626 to
9978104
Compare
cjpatton
force-pushed
the
cjpatton/947-7-prep-state-serialization
branch
from
5449de6 to
6e1662f
Compare
|
Changed base to main. |
Merged
cjpatton
commented
Jan 7, 2025
| (mastic, agg_param): &(&Mastic<T, P, SEED_SIZE>, &MasticAggregationParam), | ||
| bytes: &mut Cursor<&[u8]>, | ||
| ) -> Result<Self, CodecError> { | ||
| let output_shares = MasticOutputShare::decode_with_param(&(*mastic, *agg_param), bytes)?; |
There was a problem hiding this comment.
This may be a lot of data to store, since the length of output_shares is linear in the number of candidate prefixes. In most cases, it would be more compact to store the VIDPF seed and correction words along with the candidate prefixes. However, re-inflating would cost CPU.
cjpatton
force-pushed
the
cjpatton/947-7-prep-state-serialization
branch
from
6e1662f to
530053d
Compare
divergentdave
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #947.