Remove getrandom(), clean up error handling
#1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divergentdave
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
FWIW, gen() and fill() are technically infallible because they're unwrapping a Result, but I think that we can ignore such failures on modern mainstream systems. Note that rand::thread_rng() also unwraps a Result during per-thread initialization -- this Result comes from getrandom.
Use `thread_rng().gen::<[u8; SEED_SIZE]>()` to generate seeds rather than `getrandom()`. Since this method is infallible, we no longer need to propagate errors from `getrandom()`.
cjpatton
force-pushed
the
cjpatton/955
branch
from
da83385 to
d8e0651
Compare
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #955.
Use
thread_rng().gen::<[u8; SEED_SIZE]>()to generate seeds rather thangetrandom(). Since this method is infallible, we no longer need to propagate errors fromgetrandom().