Moved Flip and Flop to IMagickImageCreateOperations.

dlemstra · Nov 21, 2024 · e9f136c · e9f136c
1 parent 30fb91f
commit e9f136c
Show file tree

Hide file tree

Showing 5 changed files with 28 additions and 18 deletions.
diff --git a/src/Magick.NET.Core/IMagickImage.cs b/src/Magick.NET.Core/IMagickImage.cs
@@ -972,18 +972,6 @@ public partial interface IMagickImage : IMagickImageCreateOperations, IDisposabl
     /// <exception cref="MagickException">Thrown when an error is raised by ImageMagick.</exception>
     void Evaluate(Channels channels, IMagickGeometry geometry, EvaluateOperator evaluateOperator, Percentage percentage);
 
-    /// <summary>
-    /// Flip image (reflect each scanline in the vertical direction).
-    /// </summary>
-    /// <exception cref="MagickException">Thrown when an error is raised by ImageMagick.</exception>
-    void Flip();
-
-    /// <summary>
-    /// Flop image (reflect each scanline in the horizontal direction).
-    /// </summary>
-    /// <exception cref="MagickException">Thrown when an error is raised by ImageMagick.</exception>
-    void Flop();
-
     /// <summary>
     /// Obtain font metrics for text string given current font, pointsize, and density settings.
     /// </summary>

diff --git a/src/Magick.NET.Core/IMagickImageCreateOperations.cs b/src/Magick.NET.Core/IMagickImageCreateOperations.cs
@@ -494,6 +494,18 @@ public interface IMagickImageCreateOperations
     /// <exception cref="MagickException">Thrown when an error is raised by ImageMagick.</exception>
     void Extent(IMagickGeometry geometry, Gravity gravity);
 
+    /// <summary>
+    /// Flip image (reflect each scanline in the vertical direction).
+    /// </summary>
+    /// <exception cref="MagickException">Thrown when an error is raised by ImageMagick.</exception>
+    void Flip();
+
+    /// <summary>
+    /// Flop image (reflect each scanline in the horizontal direction).
+    /// </summary>
+    /// <exception cref="MagickException">Thrown when an error is raised by ImageMagick.</exception>
+    void Flop();
+
     /// <summary>
     /// Resize image to specified size.
     /// <para />

diff --git a/src/Magick.NET/MagickImage.CloneMutator.cs b/src/Magick.NET/MagickImage.CloneMutator.cs
@@ -299,6 +299,12 @@ public void Extent(IMagickGeometry geometry, Gravity gravity, IMagickColor<Quant
             Extent(geometry, gravity);
         }
 
+        public void Flip()
+            => SetResult(NativeMagickImage.Flip());
+
+        public void Flop()
+            => SetResult(NativeMagickImage.Flop());
+
         public void Resize(uint width, uint height)
             => Resize(new MagickGeometry(width, height));
 

diff --git a/src/Magick.NET/MagickImage.cs b/src/Magick.NET/MagickImage.cs
@@ -2887,7 +2887,10 @@ public void Extent(IMagickGeometry geometry, Gravity gravity, IMagickColor<Quant
     /// </summary>
     /// <exception cref="MagickException">Thrown when an error is raised by ImageMagick.</exception>
     public void Flip()
-        => _nativeInstance.Flip();
+    {
+        using var mutator = new Mutator(_nativeInstance);
+        mutator.Flip();
+    }
 
     /// <summary>
     /// Floodfill pixels matching color (within fuzz factor) of target pixel(x,y) with replacement
@@ -2951,7 +2954,10 @@ public void FloodFill(IMagickImage<QuantumType> image, int x, int y, IMagickColo
     /// </summary>
     /// <exception cref="MagickException">Thrown when an error is raised by ImageMagick.</exception>
     public void Flop()
-        => _nativeInstance.Flop();
+    {
+        using var mutator = new Mutator(_nativeInstance);
+        mutator.Flop();
+    }
 
     /// <summary>
     /// Obtain font metrics for text string given current font, pointsize, and density settings.

diff --git a/src/Magick.NET/Native/MagickImage.cs b/src/Magick.NET/Native/MagickImage.cs
@@ -410,15 +410,13 @@ private unsafe sealed partial class NativeMagickImage : NativeInstance, INativeM
         public partial IntPtr Extent(string geometry, Gravity gravity);
 
         [Throws]
-        [SetInstance]
-        public partial void Flip();
+        public partial IntPtr Flip();
 
         [Throws]
         public partial void FloodFill(DrawingSettings settings, nint x, nint y, IMagickColor<QuantumType>? target, bool invert);
 
         [Throws]
-        [SetInstance]
-        public partial void Flop();
+        public partial IntPtr Flop();
 
         [Throws]
         [Cleanup(Name = "TypeMetric.Dispose")]