Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change DPI to 96 #1781

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change DPI to 96 #1781

wants to merge 1 commit into from

Conversation

Ruben2776
Copy link

Fixes #1780

@CLAassistant
Copy link

CLAassistant commented Jan 8, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@dlemstra
Copy link
Owner

dlemstra commented Jan 9, 2025

Thanks for creating this PR but I am not sure if this would be the best solution. Maybe we could add an extra ToWriteableBitmapWithDensity method that uses the image.Density and change ToWriteableBitmap to use a density of 96? I can also make these changes myself if you don't want to do this. This should probably also include some tests to check if the dpi on the WriteableBitmap has the correct value. If that is even available in the api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect Size for ToWriteableBitmap Magick.NET.AvaloniaMediaImaging when DPI is not 96
3 participants
@Ruben2776 @CLAassistant @dlemstra