Make vcpu a block property #1141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supported attributes: count for vpus count (replaces vcpus format used previously) placement - auto or static spuset - allows binding to specific cores on host
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests is intended to close #1140
libvirt_domain vcpu field is made into block, where count is old vcpu count and placement and cpusets are also configured. As a result, specifying the latter fields allow to run libvirt domains on aarch64 SoCs with different cores via this provider. Further testing is required, however, to check other platforms still work as intended.
Note: i cannot confirm that acceptance tests are working. On aarch64 they also fail for me in current main branch.
I'll update documentation to this PR once the schema and functionality are confirmed and approved by maintainers.