hash map.

dmlc · Jan 20, 2025 · 8792ec8 · 8792ec8
1 parent be1234b
commit 8792ec8
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 5 deletions.
diff --git a/jvm-packages/xgboost4j-spark-gpu/src/main/java/ml/dmlc/xgboost4j/java/QuantileDMatrix.java b/jvm-packages/xgboost4j-spark-gpu/src/main/java/ml/dmlc/xgboost4j/java/QuantileDMatrix.java
@@ -16,6 +16,10 @@
 package ml.dmlc.xgboost4j.java;
 
 import java.util.Iterator;
+import java.util.Map;
+
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.databind.ObjectMapper;
 
 /**
  * QuantileDMatrix will only be used to train
@@ -116,8 +120,16 @@ public void setGroup(int[] group) throws XGBoostError {
   }
 
   private String getConfig(float missing, int maxBin, int nthread, boolean useExternalMemory) {
-    return String.format("{\"missing\":%f,\"max_bin\":%d,\"nthread\":%d," +
-        "\"use_ext_mem\":%b}", missing, maxBin, nthread, useExternalMemory);
+    Map<String, Object> conf = new java.util.HashMap<>();
+    conf.put("missing", missing);
+    conf.put("max_bin", maxBin);
+    conf.put("nthread", nthread);
+    conf.put("use_ext_mem", useExternalMemory);
+    ObjectMapper mapper = new ObjectMapper();
+    try {
+      return mapper.writeValueAsString(conf);
+    } catch (JsonProcessingException e) {
+      throw new RuntimeException("Failed to serialize configuration", e);
+    }
   }
-
 }
diff --git a/jvm-packages/xgboost4j/src/main/java/ml/dmlc/xgboost4j/java/Communicator.java b/jvm-packages/xgboost4j/src/main/java/ml/dmlc/xgboost4j/java/Communicator.java
@@ -3,8 +3,6 @@
 import java.io.Serializable;
 import java.nio.ByteBuffer;
 import java.nio.ByteOrder;
-import java.util.LinkedList;
-import java.util.List;
 import java.util.Map;
 
 import com.fasterxml.jackson.core.JsonProcessingException;

diff --git a/src/c_api/c_api_error.h b/src/c_api/c_api_error.h
@@ -17,12 +17,19 @@
   LOG(CONSOLE) << "[XGBoost C API invocation] " << __PRETTY_FUNCTION__;        \
   try {                                                                        \
     auto __guard = ::xgboost::XGBoostAPIGuard();
+
+#define API_BEGIN_UNGUARD()                                             \
+  LOG(CONSOLE) << "[XGBoost C API invocation] " << __PRETTY_FUNCTION__; \
+  try {
+
 #else  // LOG_CAPI_INVOCATION
+
 #define API_BEGIN()                                                            \
   try {                                                                        \
     auto __guard = ::xgboost::XGBoostAPIGuard();
 
 #define API_BEGIN_UNGUARD() try {
+
 #endif  // LOG_CAPI_INVOCATION
 
 /*! \brief every function starts with API_BEGIN();