-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve design and address comments in the new CI #11079
Conversation
Also combine build-cuda.sh / build-cuda-with-rmm.sh
Also: * Remove publish-artifacts.sh * Upload artifacts to /{commit_id}/ prefix
@trivialfis Most of the changes here are stylistic and do not affect the development process too much. However, this pull request contains one major change that significantly changes the development flow. Currently, we build Docker containers on the fly as part of the CI run for the pull request. But after this PR, we will start to have a separate CI pipeline to build and push CI containers in https://github.com/dmlc/xgboost-devops. Why the change?To make the code more legible and easier to reason about. The current script
Often a workflow would call This PR separates the concerns by having each script do one thing only.
To ensure that the container stays up to date. In the current setup, we use the Docker registry as a caching layer for containers. This setup suffers from two problems.
In the new setting, Lastly, other projects also de-couples building of CI containers from the consumption. Example: LightGBM, Rapids. I've written a guide to show how CI containers are updated: https://xgboost--11079.org.readthedocs.build/en/11079/contrib/ci.html#making-changes-to-ci-containers. Can you take a look at it and see if it makes sense? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Responding to the @
from #11046 (comment) ... sorry I couldn't get to it sooner!
I know this is already merged, but left a few small suggestions you might want to. consider for followup. All very minor... I don't have any other significant structural changes to request.
This looks awesome! Thanks so much for giving me the opportunity to review and for talking through all the comments I left on #11046 with me.
Follow up to #11001
Apply feedback from #11046. See #11046 to learn about the rationale for changes.