-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Unpin Dask, adopt CUDA 12.8 and RAPIDS 24.12 #11194
Conversation
@trivialfis We have a problem here: Latest RAPIDS cannot be installed with Dask 2024.10.0, and yet our tests cannot pass with latest Dask. 😢 |
Thanks Hyunsu! 🙏 What are the failures we are seeing? |
See:
|
I assume it's caused by dask dataframe. Can we disable some of the tests for now? Or use arrays in place of dataframes? I think it will take some time for dask to go over all the issues. It's unlikely we halt the ci for that. |
Yes, I'll probably skip the problematic test, as done in the 2.1 branch: xgboost/tests/test_distributed/test_gpu_with_dask/test_gpu_with_dask.py Lines 388 to 393 in 62e7923
|
@trivialfis I change the CI scripts a bit to make it easy to test new CI images. Now we only have to change a single file TODO.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, one minor question.
@@ -10,6 +10,7 @@ | |||
import pytest | |||
from hypothesis import given, note, settings, strategies | |||
from hypothesis._settings import duration | |||
from packaging.version import parse as parse_version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not in the stdlib, do we need to specify it in our testing environments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, our CI already has packaging
installed (due to it being a dependency of other packages we use). However, if we were to add a [test]
suite for optional dependencies in pyproject.toml, we should have packaging
in that suite.
Related: dmlc/xgboost-devops#9, dmlc/xgboost-devops#11
Use latest Dask, CUDA 12.8, and RAPIDS 24.12.
Also it's now easy to update the image tag in all pipelines simultaneously.