Resolve create() with WriteResult #29

dmurvihill · 2019-11-19T19:22:54Z

Reopening the original PR here.

…content must be served

This has been the default for Firebase for a while now.

Previously, when a document have a reference to another document, we ended up in an infinite loop. This is now prevented by only follow plain objects. This logic makes it easier to reason about the call chain too.

Previous behavior for Server Timestamp was to return UNIX timestamp. This is the correct bahviour still for the client firebase.database library. This change restores this.

Internally date is now stored as Date until returned, where it is converted to Timestamp. This fixes orderBy.

dmurvihill · 2019-11-20T22:48:31Z

Hi @op, we're running into the same issue here as we did with #31 -- this is only available through firebase.admin and not through firebase. Needs resolution.

Previously, gulp-shell did not properly signal completion, resulting in errors with Gulp 4. Fixed now.

# Conflicts: # src/storage-bucket.js # src/storage.js

Fix: Add Boolean support to Query equalTo

Pass a `User` into the setup instead of a plain object. Also, fix one typo in a test name.

Firebase SDK [Version 4.0.0](https://firebase.google.com/support/release-notes/js#version_500_-_may_8_2018) changed the behavior of `onAuthStateChanged` and added a new event handler called `onIdTokenChanged`. This patch mocks that change. onIdTokenChanged now implements the former behavior of onAuthStateChanged. onAuthStateChanged now signals only when the actual user changes, not when a new ID token is set for the same user.

joelpoloney · 2019-12-24T00:24:23Z

Hi @op, we're running into the same issue here as we did with #31 -- this is only available through firebase.admin and not through firebase. Needs resolution.

Is this really an issue? Why not support it regardless? What's the downside of adding it in?

Change NPM URLs to new repo

Remove two unused imports

# Conflicts: # CHANGELOG.md

# Conflicts: # package-lock.json # src/firestore-document-snapshot.js # src/firestore-document.js # src/firestore-query.js # src/utils.js # test/unit/firestore-collection.js # test/unit/utils.js

Timestamp

…mock into create-write-result

dmurvihill · 2020-01-08T18:38:56Z

I'm realizing now that this PR doesn't make the problem any worse than it already is.

We have an issue where if you call .firestore() on a mock SDK, you will get a sort of half-regular and half-admin Frankenmock. For instance, MockFirestoreDocument has a create method even though that method exists only on the admin SDK, but most of its other methods return Promise<void> which is consistent with the regular SDK.

You're right that none of that has anything to do with this PR, so I'm going to merge it. Cheers.

joelpoloney · 2020-01-08T20:52:53Z

Thank you 🙏

Tomas Rupsys and others added 17 commits January 18, 2019 16:15

fix(storage): handling the case when destination is not provided and …

0aafc8f

…content must be served

fix(storage): new file should be created every time

9c12e14

fix(storage): do not recreate bucket every time

2050c7f

fix(storage): buffer should be sent as an array

0c8659c

Add Timestamp

78d29be

Resolve create() with the write time

c0aee17

Move server clock handling out to utils

e77ea3e

Use serverClock in WriteResult

4563e8f

Add lodash isPlainObject dependency

da2895a

Return Timestamp for date related fields

b8a2ebb

This has been the default for Firebase for a while now.

Fix infinite recursion on ref

7796810

Previously, when a document have a reference to another document, we ended up in an infinite loop. This is now prevented by only follow plain objects. This logic makes it easier to reason about the call chain too.

Expose Timestamp in SDK

f4ac5ef

Restore some of the Server Timestamp logic

2ff0039

Previous behavior for Server Timestamp was to return UNIX timestamp. This is the correct bahviour still for the client firebase.database library. This change restores this.

Fix orderBy for fields containing Date

532af4c

Internally date is now stored as Date until returned, where it is converted to Timestamp. This fixes orderBy.

Add test for orderBy with Date

f614189

Use same server time in WriteResult as in docs

41174bc

Merge branch 'master' into create-write-result

6fe4e0b

dmurvihill mentioned this pull request Nov 19, 2019

Resolve create() with WriteResult soumak77/firebase-mock#135

Open

dmurvihill and others added 2 commits November 19, 2019 15:30

Merge branch 'master' into thomasrup-master

4c0e7de

call onAuthStateChanged callback immediately

4b187d7

dmurvihill and others added 5 commits November 21, 2019 11:03

Merge branch 'call-onautstatechanged-immediately' into v3.0

731888e

removed .vscode

a2d7ec1

removed extra space

b9135cf

Merge branch 'thomasrup-master' into v3.0

39cb1d0

Add changelog

bf6393f

dmurvihill added 2 commits December 11, 2019 15:06

Update gulp shell plugin

21e07f2

Previously, gulp-shell did not properly signal completion, resulting in errors with Gulp 4. Fixed now.

Merge branch 'master' into v3.0

cf32575

# Conflicts: # src/storage-bucket.js # src/storage.js

raman-nbg and others added 14 commits December 18, 2019 23:45

Fix docs for Messaging

f99c9fb

Add API Reference for MockMessaging

0ee4189

Add Changelog for Messaging support

fe1850e

Minor changelog update

774503e

Merge pull request #46 from Redmega/master

a1957f1

Fix: Add Boolean support to Query equalTo

Clean up auth and user tests

d8e73dd

Pass a `User` into the setup instead of a plain object. Also, fix one typo in a test name.

Add a couple of extra auth/user tests

6469bd9

Remove a few warnings from auth

90f35ab

Merge branch 'master' into onIdTokenChanged

e92a4ba

Quick changelog fix

23a6289

Remove two unused imports

846d890

Fix unit test

57b4a22

Fix typo in API docs

f687e89

dmurvihill added 10 commits December 30, 2019 14:40

Change NPM URLs to new repo

a6e627e

Merge pull request #49 from dmurvihill/fix-repo-url

744d6b0

Change NPM URLs to new repo

Make docs match tests

891551e

Merge pull request #43 from raman-nbg/messaging

ba6acb0

Merge pull request #48 from dmurvihill/remove-warnings

496b37f

Remove two unused imports

Merge branch 'onIdTokenChanged'

3175bb8

# Conflicts: # CHANGELOG.md

Merge remote-tracking branch 'origin/master' into timestamp

d65329d

# Conflicts: # package-lock.json # src/firestore-document-snapshot.js # src/firestore-document.js # src/firestore-query.js # src/utils.js # test/unit/firestore-collection.js # test/unit/utils.js

Merge pull request #27 from dmurvihill/timestamp

467ecc0

Timestamp

Merge branch 'master' of github.com:dmurvihill/firebase-mock

ab258e1

Merge branch 'create-write-result' of github.com:dmurvihill/firebase-…

d883b80

…mock into create-write-result

dmurvihill merged commit f9bf0c7 into master Jan 8, 2020

dmurvihill deleted the create-write-result branch January 8, 2020 21:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Resolve create() with WriteResult #29

Resolve create() with WriteResult #29

dmurvihill commented Nov 19, 2019

dmurvihill commented Nov 20, 2019

joelpoloney commented Dec 24, 2019

dmurvihill commented Jan 8, 2020

joelpoloney commented Jan 8, 2020

Resolve create() with WriteResult #29

Resolve create() with WriteResult #29

Conversation

dmurvihill commented Nov 19, 2019

dmurvihill commented Nov 20, 2019

joelpoloney commented Dec 24, 2019

dmurvihill commented Jan 8, 2020

joelpoloney commented Jan 8, 2020