Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
RNTester - Legacy component example: do not convert commands to string (
facebook#42822) Summary: The conversion to string was introduced in D45043929. It was supposed to fix command execution for `MyLegacyNativeComponent` in RNTester on Android/Old Architecture. At the same time it introduced a regression on iOS, since we have [different code path](https://www.internalfb.com/code/fbsource/[ffee789cab9514c0a15b8a63869cbfdf4e534a56]/xplat/js/react-native-github/packages/react-native/React/Modules/RCTUIManager.m?lines=1088-1092) for string commands in iOS, where we expect command name, and not command number converted to string. I tried to remove that conversion, did local tests, and saw no issues with executing commands on Android. Looks like the underlying issue has been fixed in some other way. So let's just remove those conversions. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D53123956
- Loading branch information