Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[# 139] 사용자 정보 등록 페이지에서 위치 등록시 레이아웃 깨지던 문제 해결 #140

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

gihwan-dev
Copy link
Collaborator

What is this PR? 🔍

사용자 정보 등록 페이지의 위치 퍼널에서 위치 검색시 레이아웃이 깨지던 문제 해결했습니다!

Changes 📝

  • 부가적으로 에러 상태 관리 하도록 했고 서치 파라미터가 비어있으면 요청을 보내지 않도록 했습니다.

Screenshot 📷

Copy link

vercel bot commented Aug 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dnd-11th-8-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 6:04am
dnd-11th-8-frontend-rvo5 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 6:04am

@gihwan-dev
Copy link
Collaborator Author

Test Coverage

[email protected] coverage /home/runner/work/dnd-11th-8-frontend/dnd-11th-8-frontend
vitest run --coverage

RUN v2.0.5 /home/runner/work/dnd-11th-8-frontend/dnd-11th-8-frontend
Coverage enabled with v8

src/test/utils/dateUtils.test.ts (4 tests) 6ms
src/test/utils/SomeTest.test.tsx (1 test) 70ms
src/test/utils/validation.test.ts (2 tests) 4ms
src/test/utils/sum.test.ts (1 test) 3ms

Test Files 4 passed (4)
Tests 8 passed (8)
Start at 06:04:24
Duration 3.40s (transform 86ms, setup 733ms, collect 73ms, tests 83ms, environment 1.98s, prepare 404ms)

% Coverage report from v8

=============================== Coverage summary ===============================

Statements   : 0.14% ( 11/7563 )
Branches     : 7.37% ( 16/217 )
Functions    : 3.82% ( 8/209 )
Lines        : 0.14% ( 11/7563 )
================================================================================

@gihwan-dev gihwan-dev merged commit 9da3d82 into main Aug 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fix] 사용자 정보 등록 페이지 주소 길어질때 UI 수정"
1 participant