Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[# 191] 내 식물 알림 수정 기능 구현 #214

Merged
merged 8 commits into from
Sep 10, 2024
Merged

[# 191] 내 식물 알림 수정 기능 구현 #214

merged 8 commits into from
Sep 10, 2024

Conversation

gihwan-dev
Copy link
Collaborator

What is this PR? 🔍

내 식물 알림 수정 기능 구현

Changes 📝

  • 알림 토글 리스트 컴포넌트 인터페이스에 전체 알림 수정시 동작하는 함수 추가
  • 알림 수정시 낙관적 업데이트 적용
  • 전체 알림 off시 값 초기화 하도록 수정

Screenshot 📷

@gihwan-dev gihwan-dev self-assigned this Sep 10, 2024
Copy link

vercel bot commented Sep 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dnd-11th-8-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 1:36pm
dnd-11th-8-frontend-rvo5 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 1:36pm

@gihwan-dev
Copy link
Collaborator Author

Test Coverage

[email protected] coverage /home/runner/work/dnd-11th-8-frontend/dnd-11th-8-frontend
vitest run --coverage

RUN v2.0.5 /home/runner/work/dnd-11th-8-frontend/dnd-11th-8-frontend
Coverage enabled with v8

src/test/utils/dateUtils.test.ts (4 tests) 5ms
src/test/utils/validation.test.ts (2 tests) 4ms
src/test/utils/SomeTest.test.tsx (1 test) 64ms
src/test/utils/sum.test.ts (1 test) 3ms

Test Files 4 passed (4)
Tests 8 passed (8)
Start at 13:37:01
Duration 3.62s (transform 74ms, setup 752ms, collect 61ms, tests 76ms, environment 1.95s, prepare 392ms)

% Coverage report from v8

=============================== Coverage summary ===============================

Statements   : 0.1% ( 9/8509 )
Branches     : 6.89% ( 18/261 )
Functions    : 5.44% ( 14/257 )
Lines        : 0.1% ( 9/8509 )
================================================================================

@gihwan-dev gihwan-dev merged commit 16ca8c2 into main Sep 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] 내 식물 상세 페이지 알림 수정 토글 서버 연결
1 participant