Dynamically loading the "whats new" #553
Conversation
dperrymorrow
added
site-generator
whatever ruby is doing the deploy does not like that
content/index.html.erb
Outdated
| @@ -9,55 +9,55 @@ <h2 class="pv2 normal">Get your DNS hosting and domains set up and running quick | |||
| <div class="pv4 flex flex-wrap justify-center justify-start-ns"> | |||
| <div class="text-centered mr3"> | |||
| <a class="tc link dim" href="https://dnsimple.com/api/ruby?utm_source=developer&utm_medium=web&utm_content=cta-lang" target="_blank"> | |||
| <img class="h2 w3" src="/assets/images/ruby.svg"> | |||
| <img class="h2 w3" src="/assets/images/ruby.svg" /> | |||
There was a problem hiding this comment.
Are all the /> changes done in purpose or is your IDE closing them?
There was a problem hiding this comment.
My IDE is closing them, but they should be closed no?
| @@ -91,42 +91,47 @@ <h2 class="pa0 pb1">Popular articles</h2> | |||
| </div> | |||
| </div> | |||
|
|
|||
| <% featured = blog_articles %> | |||
There was a problem hiding this comment.
Why do you alias blog_articles with featured instead of using blog_articles directly? Maybe blog_articles is not a good name? ;)
There was a problem hiding this comment.
I didnt want it to make the network request to the blog more than once. Not sure if that really matters since this is at compile time and not run time, but yeah...
|
@dperrymorrow anything holding this PR to go live? |
no, I was trying to do the same for the support site, but @sbastn and I were running into unexpected issues. Not sure if it makes sense to have support dynamic while still having to manually update support site. Seb pointed out my IDE closed those |
Dynamically loading "Whats New" features listed on developer site from the blog.
Belongs to: 691
Loading feed.json from the blog, filtering by "Feature" then displaying the first three posts under the "whats new" section on the homepage.
Previously this was done manually each time we released a new post about a feature.
QA: