Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new docs section for DNS Analytics #557

Merged
merged 10 commits into from
Feb 6, 2024
Merged

Add new docs section for DNS Analytics #557

merged 10 commits into from
Feb 6, 2024

Conversation

ggalmazor
Copy link
Contributor

@ggalmazor ggalmazor commented Jan 31, 2024 •
edited
Loading

In this PR:

  • New section for the DNS Analytics endpoint

image

@ggalmazor ggalmazor self-assigned this Jan 31, 2024
@ggalmazor ggalmazor added the task One or more no-coding actions to execute for this project. label Jan 31, 2024
jacegu
jacegu reviewed Feb 1, 2024
View reviewed changes
Copy link
Contributor

@jacegu jacegu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to clarify some bits before moving forward.

content/v2/dns-analytics.markdown Outdated Show resolved Hide resolved
content/v2/dns-analytics.markdown Outdated Show resolved Hide resolved
content/v2/dns-analytics.markdown Outdated Show resolved Hide resolved
@ggalmazor ggalmazor requested a review from jacegu February 1, 2024 08:21
jacegu
jacegu approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@jacegu jacegu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I believe this is ready for @itsalyse's eyes.

content/v2/dns-analytics.markdown Outdated Show resolved Hide resolved
content/v2/dns-analytics.markdown Outdated Show resolved Hide resolved
@ggalmazor ggalmazor requested review from itsalyse and removed request for juankuquintana February 1, 2024 09:27
@itsalyse
minor edits
12cb9bf 
adds some punctuation
removes repeated copy
@itsalyse
adds period
4db21b0
@ggalmazor ggalmazor merged commit e61d11d into main Feb 6, 2024
7 checks passed
@ggalmazor ggalmazor deleted the change/add_docs_about_dns_analytics_endpoint branch February 6, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacegu jacegu jacegu approved these changes

@itsalyse itsalyse itsalyse approved these changes

Assignees

@ggalmazor ggalmazor

Labels
task One or more no-coding actions to execute for this project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggalmazor @jacegu @itsalyse