Update domain delegation name servers to a set (#186)

* update domain delegation name servers to a set --------- Co-authored-by: DXTimer <[email protected]>
dnsimple · Jan 24, 2024 · bc71acb · bc71acb
1 parent 7d5e7c3
commit bc71acb
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 9 deletions.
diff --git a/internal/framework/resources/domain_delegation_resource.go b/internal/framework/resources/domain_delegation_resource.go
@@ -10,7 +10,6 @@ import (
 	"github.com/hashicorp/terraform-plugin-framework/path"
 	"github.com/hashicorp/terraform-plugin-framework/resource"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema"
-	"github.com/hashicorp/terraform-plugin-framework/resource/schema/listplanmodifier"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema/stringplanmodifier"
 	"github.com/hashicorp/terraform-plugin-framework/types"
@@ -39,7 +38,7 @@ type DomainDelegationResource struct {
 type DomainDelegationResourceModel struct {
 	Id          types.String `tfsdk:"id"`
 	Domain      types.String `tfsdk:"domain"`
-	NameServers types.List   `tfsdk:"name_servers"`
+	NameServers types.Set    `tfsdk:"name_servers"`
 }
 
 func (r *DomainDelegationResource) Metadata(ctx context.Context, req resource.MetadataRequest, resp *resource.MetadataResponse) {
@@ -58,12 +57,9 @@ func (r *DomainDelegationResource) Schema(_ context.Context, _ resource.SchemaRe
 					stringplanmodifier.RequiresReplace(),
 				},
 			},
-			"name_servers": schema.ListAttribute{
+			"name_servers": schema.SetAttribute{
 				Required:    true,
 				ElementType: types.StringType,
-				PlanModifiers: []planmodifier.List{
-					listplanmodifier.RequiresReplace(),
-				},
 			},
 		},
 	}
@@ -190,7 +186,7 @@ func (r *DomainDelegationResource) ImportState(ctx context.Context, req resource
 }
 
 func (r *DomainDelegationResource) updateModelFromAPIResponse(ctx context.Context, delegation *dnsimple.Delegation, data *DomainDelegationResourceModel) diag.Diagnostics {
-	nameServers, diag := types.ListValueFrom(ctx, types.StringType, delegation)
+	nameServers, diag := types.SetValueFrom(ctx, types.StringType, delegation)
 	data.NameServers = nameServers
 	return diag
 }
diff --git a/internal/framework/resources/domain_delegation_resource_test.go b/internal/framework/resources/domain_delegation_resource_test.go
@@ -27,8 +27,20 @@ func TestAccDomainDelegationResource(t *testing.T) {
 					resource.TestCheckResourceAttrSet(resourceName, "id"),
 					resource.TestCheckResourceAttr(resourceName, "domain", domainId),
 					resource.TestCheckResourceAttr(resourceName, "name_servers.#", "2"),
-					resource.TestCheckResourceAttr(resourceName, "name_servers.0", "ns-998.awsdns-60.net"),
-					resource.TestCheckResourceAttr(resourceName, "name_servers.1", "ns-1556.awsdns-02.co.uk"),
+					resource.TestCheckTypeSetElemAttr(resourceName, "name_servers.*", "ns-998.awsdns-60.net"),
+					resource.TestCheckTypeSetElemAttr(resourceName, "name_servers.*", "ns-1556.awsdns-02.co.uk"),
+				),
+			},
+			{
+				Config:             testAccDomainDelegationResourceConfigReversed(domainId),
+				ExpectNonEmptyPlan: false,
+				PlanOnly:           true,
+				Check: resource.ComposeAggregateTestCheckFunc(
+					resource.TestCheckResourceAttrSet(resourceName, "id"),
+					resource.TestCheckResourceAttr(resourceName, "domain", domainId),
+					resource.TestCheckResourceAttr(resourceName, "name_servers.#", "2"),
+					resource.TestCheckTypeSetElemAttr(resourceName, "name_servers.*", "ns-998.awsdns-60.net"),
+					resource.TestCheckTypeSetElemAttr(resourceName, "name_servers.*", "ns-1556.awsdns-02.co.uk"),
 				),
 			},
 			{
@@ -69,3 +81,11 @@ resource "dnsimple_domain_delegation" "test" {
 	name_servers = ["ns-998.awsdns-60.net", "ns-1556.awsdns-02.co.uk"]
 }`, domainId)
 }
+
+func testAccDomainDelegationResourceConfigReversed(domainId string) string {
+	return fmt.Sprintf(`
+resource "dnsimple_domain_delegation" "test" {
+	domain = %[1]q
+	name_servers = ["ns-1556.awsdns-02.co.uk", "ns-998.awsdns-60.net"]
+}`, domainId)
+}