Skip to content

Commit

Permalink
more logging
Browse files Browse the repository at this point in the history
  • Loading branch information
jschlyter committed Sep 11, 2024
1 parent c525e36 commit 23a97ff
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
1 change: 1 addition & 0 deletions aggrec/server.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ def __init__(self, settings: Settings):
self.include_router(aggrec.extras.router)
configure_opentelemetry(
self,
service_name="aggrec",
spans_endpoint=str(settings.otlp.spans_endpoint),
metrics_endpoint=str(settings.otlp.metrics_endpoint),
insecure=settings.otlp.insecure,
Expand Down
11 changes: 10 additions & 1 deletion aggrec/telemetry.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import logging

from fastapi import FastAPI
from opentelemetry import metrics, trace
from opentelemetry.exporter.otlp.proto.grpc.metric_exporter import OTLPMetricExporter
Expand All @@ -14,14 +16,17 @@
from opentelemetry.sdk.trace import TracerProvider
from opentelemetry.sdk.trace.export import BatchSpanProcessor, ConsoleSpanExporter

logger = logging.getLogger(__name__)


def configure_opentelemetry(
app: FastAPI,
service_name: str,
spans_endpoint: str | None = None,
metrics_endpoint: str | None = None,
insecure: bool = True,
) -> None:
resource = Resource(attributes={SERVICE_NAME: "aggrec"})
resource = Resource(attributes={SERVICE_NAME: service_name})

traceProvider = TracerProvider(resource=resource)

Expand All @@ -32,6 +37,7 @@ def configure_opentelemetry(
)
traceProvider.add_span_processor(processor)
trace.set_tracer_provider(traceProvider)
logger.debug("OTLP spans via %s", spans_endpoint or "console")

reader = PeriodicExportingMetricReader(
OTLPMetricExporter(endpoint=metrics_endpoint, insecure=insecure)
Expand All @@ -40,6 +46,7 @@ def configure_opentelemetry(
)
meterProvider = MeterProvider(resource=resource, metric_readers=[reader])
metrics.set_meter_provider(meterProvider)
logger.debug("OTLP metrics via %s", metrics_endpoint or "console")

FastAPIInstrumentor.instrument_app(
app=app,
Expand All @@ -51,3 +58,5 @@ def configure_opentelemetry(
)
PymongoInstrumentor().instrument()
BotocoreInstrumentor().instrument()

logger.info("OpenTelemetry configured")

0 comments on commit 23a97ff

Please sign in to comment.