Initial support for OpenTelemetry #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eest
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
The only thing I am uncertain about is if it is better to name spans more closely to the functions they wrap, e.g. replacing the name "s3.put_object" with "s3_client.put_object" which is actually being called, mainly because it means when inspecting trace data you always talk about the same things being called and is one layer less of indirection. But it is not a dealbreaker for me, so LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send traces and basic metrics via OTLP. Need review feedback on terminology and configuration parameters.