Key id format (#42)

* Key identifiers may contain . * bump
dnstapir · Jan 8, 2025 · d104c5a · d104c5a
1 parent e8ca973
commit d104c5a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/dnstapir/key_resolver.py b/dnstapir/key_resolver.py
@@ -35,7 +35,7 @@ def key_resolver_from_client_database(client_database: str, key_cache: KeyCache
 class KeyResolver:
     def __init__(self):
         self.logger = logging.getLogger(__name__).getChild(self.__class__.__name__)
-        self.key_id_validator = re.compile(r"^[a-zA-Z0-9_-]+$")
+        self.key_id_validator = re.compile(r"^[a-zA-Z0-9_\-.]+$")
 
     @abstractmethod
     def resolve_public_key(self, key_id: str) -> PublicKey:

diff --git a/pyproject.toml b/pyproject.toml
@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "dnstapir"
-version = "1.2.1"
+version = "1.2.2"
 description = "DNS TAPIR Python Library"
 authors = ["Jakob Schlyter <[email protected]>"]
 readme = "README.md"

diff --git a/tests/test_key_resolver.py b/tests/test_key_resolver.py
@@ -25,6 +25,9 @@ def test_file_key_resolver(httpx_mock: HTTPXMock):
         res = resolver.resolve_public_key(key_id)
         assert res == public_key
 
+        with pytest.raises(KeyError):
+            _ = resolver.resolve_public_key("hostname.example.com")
+
         with pytest.raises(ValueError):
             _ = resolver.resolve_public_key("🔐")