Install pure Ruby sqlite3 gem #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Docker images pushed to Docker Hub for tagged versions `latest`, `0`, `0.9`, and `0.9.0` [1], published on 22 August 2023, include several notable changes [2]: - Alpine Linux update from 3.15.4 to 3.16.7 - Mailcatcher 0.8.2 to 0.9.0 The former is significant as it includes a Ruby update from 3.0.4 to 3.1.4, though I don't believe that is introducing the issues detailed in #9. The latter is significant as the build updates this gem's sqlite3 dependency from 1.4.4 (pure Ruby gem) to 1.6.3 (platform-native gem). The sqlite3 gem introduced platform-native builds from 1.5.0 [3], first published in July/September 2022. As noted in the aforementioned issue, the published Docker images for ARM platforms are failing to launch. #10 proposes adding the `gcompat` package to install glibc-compatible libraries into Alpine. I've used that on other projects running Alpine Linux to install Nokogiri, etc. Unfortunately, as I note in my comment on that PR, the resulting image crashes on a _different_ error [4]. The proposed change here (reintroducing the pure Ruby sqlite3 gem) works around what might be a rabbit hole of issues I'm not equipped to solve. This _does_ result in longer Docker image build times, but I don't think that will negatively impact downstream consumers of the published images. Addresses #9. [1] https://hub.docker.com/r/dockage/mailcatcher/tags [2] v0.8.2...v0.9.0 [3] https://rubygems.org/gems/sqlite3/versions [4] #10 (comment)
|
Alternatively, Mailcatcher's author publishes Docker images at: https://hub.docker.com/r/sj26/mailcatcher Their |
|
Found the same solution from the same author. Work for me. |
|
Just missing this PR to be merged, and publish the image to be good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Docker images pushed to Docker Hub for tagged versions
latest,0,0.9, and0.9.0(link), published on 22 August 2023, include several notable changes (compare):The former is significant as it includes a Ruby update from 3.0.4 to 3.1.4, though I don't believe that is introducing the issues detailed in #9.
The latter is significant as the build updates this gem's sqlite3 dependency from 1.4.4 (pure Ruby gem) to 1.6.3 (platform-native gem). The sqlite3 gem introduced platform-native builds from 1.5.0 (RubyGems version history), first published in July/September 2022.
As noted in the aforementioned issue, the published Docker images for ARM platforms are failing to launch.
#10 proposes adding the
gcompatpackage to install glibc-compatible libraries into Alpine. I've used that on other projects running Alpine Linux to install Nokogiri, etc. Unfortunately, as I note in my comment on that PR, the resulting image crashes on a different error.The proposed change here (reintroducing the pure Ruby sqlite3 gem) works around what might be a rabbit hole of issues I'm not equipped to solve.
This does result in longer Docker image build times, but I don't think that will negatively impact downstream consumers of the published images.
Addresses #9.