-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PECL wrapper commands #1339
Conversation
docker-php-pecl-configure
Outdated
echo " ie: $0 apcu --enable-apcu-spinlocks" | ||
echo " $0 -j5 apcu redis grpc protobuf" | ||
echo | ||
echo 'if custom ./configure arguments are necessary, see docker-php-pecl-configure' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This refers to itself. Is that correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This is redundant and has been removed.
Error caused by copy & paste.
See #919, especially #919 (comment) -- I haven't seen the deprecation of To add just a little bit more meat here, my biggest concern is maintaining yet-more code above and beyond what is distributed by the PHP project, especially for something that is in most cases reasonably straightforward already, even with cleanup of dependencies (#919 (comment)), and even more especially that does so in an unconventional way (we've got a few of those, and they're definitely sources of friction for users and maintainers). I imagine the number of extensions where |
@tianon However, since PECL is already in maintenance mode and deprecated, I do not see any new functionality being incorporated. That said, PECL is currently the only repository for PHP extensions, and many extensions are hosted in PECL. For the above reasons, docker-php still expects to support PECL even after its deprecation. In light of this situation, we believe it would be appropriate to incorporate a follow-up to PECL on the docker-php side. On the other hand, PHP certainly needs to resolve the issue of hosting Native Extensions. |
I'm sorry, but we do not expect this, actually -- if PECL is finally removed, we will not be doing anything but removing any reference to it. 😅 |
PECL use is currently supported, but PECL by default does not support parallel compilation like the -j option, and huge extensions such as gRPC take a huge amount of build time.
To solve this problem, we add a script that wraps PECL.
This is useful because so far PECL is the only native extension package manager for PHP and has many useful and essential extensions for production environments (gRPC, protobuf, APCu, Redis, etc.).