vendor: remove vendor ;) #5856
Open
vendor: remove vendor ;) #5856
+1,860
−887,046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We might want to include #4228 as part of this. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5856 +/- ##
==========================================
- Coverage 59.30% 59.27% -0.03%
==========================================
Files 353 353
Lines 29694 29694
==========================================
- Hits 17609 17601 -8
- Misses 11104 11113 +9
+ Partials 981 980 -1 |
thaJeztah
requested changes
Feb 21, 2025
Ok, how do we do this so it doesn't break the release pipeline? |
The current vendoring setup makes it difficult for new developers to get started on the repository. It seems to be this way to address the problems with adoption across the Docker and Moby repositories. At this point, many of those issues seem to be behind us so it's worth a try again to make this project simpler to work on. Signed-off-by: Stephen Day <[email protected]>
stevvooe
force-pushed
the
sjd/remove-vendoring
branch
from
f77c758 to
4fd1866
Compare
Signed-off-by: Stephen Day <[email protected]>
Signed-off-by: Stephen Day <[email protected]>
Signed-off-by: Stephen Day <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current vendoring setup makes it difficult for new developers to get started on the repository. It seems to be this way to address the problems with adoption across the Docker and Moby repositories. At this point, many of those issues seem to be behind us so it's worth a try again to make this project simpler to work on.
- What I did
Removed vendoring. I did it with a hammer, so we might need to make some repairs.
- How I did it
With a hammer. 🔨
- How to verify it
We should see CI build as normal. Downstream tests, such as moby, should pass as normal.
There were some areas that were using the term "vendor" in a plugin context. We should see NO regressions in that behavior.
- A picture of a cute animal (not mandatory but encouraged)