Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Go 1.13.8 #53

Merged
merged 1 commit into from
Feb 26, 2020
Merged

Conversation

thaJeztah
Copy link
Member

This updates the image for Go 1.13. Note that the Apple SDK that
is hosted on s3.mobyproject.org is an older version, which does
not allow specifying the "minimum macOS version" to be 1.11 (the
minimum version supported by Go 1.13).

TODO comments were added to the Dockerfile to document this, and
to update the version once an updated SDK is available.

closes #42
closes #45
closes #49

This updates the image for Go 1.13. Note that the Apple SDK that
is hosted on s3.mobyproject.org is an older version, which does
not allow specifying the "minimum macOS version" to be 1.11 (the
minimum version supported by Go 1.13).

TODO comments were added to the Dockerfile to document this, and
to update the version once an updated SDK is available.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah mentioned this pull request Feb 25, 2020
@thaJeztah
Copy link
Member Author

@silvin-lubecki @vdemeester PTAL

Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

Copy link
Contributor

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(We can finally move forward!

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki silvin-lubecki merged commit 011e352 into docker:master Feb 26, 2020
@thaJeztah thaJeztah deleted the bump_golang_1.13 branch February 26, 2020 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants