Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Improve compose file #146

Closed
wants to merge 2 commits into from

Conversation

oregonpillow
Copy link

Closes #145

open to suggestions

@oregonpillow
Copy link
Author

make the compose file "self-describing" and following standard compose practices:

  • explicitly set / describe all environment variables within compose
  • include commented options when settings are optional (e.g usb pass through)
  • comments to improve readability
  • mounting persistent data next to compose file

@kroese
Copy link
Contributor

kroese commented Dec 20, 2024

Thanks for your efforts, but I'd rather keep it the way it is. To start off, those values suggested for cpu/ram/disk are different from the current default values. Also, there are many many more variables that can be set, about 30 of them and if we would include them all, it would become a huge compose file.

So it was a very deliberate decision to keep the example compose file reduced to the absolute minimum and as short as possible, so that people do not get overwhelmed by it.

@kroese kroese closed this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Improve compose file
2 participants