Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The use of bash in main.sh and logger.sh #5

Closed
dodona-server opened this issue Aug 1, 2019 · 1 comment · Fixed by #22
Closed

The use of bash in main.sh and logger.sh #5

dodona-server opened this issue Aug 1, 2019 · 1 comment · Fixed by #22
Labels

Comments

@dodona-server
Copy link
Contributor

The R docker image I'm preparing, is based on alpine linux and doesn't come with a bash shell (alpine uses the ash shell).

Can #!/bin/bash be replaced with #!/bin/sh in main.sh and logger.sh? If not, I'll install the bash shell in the docker image (but I like to keep it as minimal as possible).

Original issue by jfmeys on Thu Apr 05 2018 at 17:55.

@beardhatcode beardhatcode mentioned this issue Aug 1, 2019
9 tasks
@beardhatcode
Copy link
Member

I think it can and it wouldn't break anything.

But this should be tested first

Original comment by @beardhatcode on Thu Apr 05 2018 at 22:49.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants