Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change bash to sh #6

Closed
wants to merge 1 commit into from
Closed

Change bash to sh #6

wants to merge 1 commit into from

Conversation

beardhatcode
Copy link
Member

The R docker image I'm preparing, is based on alpine linux and doesn't come with a bash shell (alpine uses the ash shell).

Can #!/bin/bash be replaced with #!/bin/sh in main.sh and logger.sh? If not, I'll install the bash shell in the docker image (but I like to keep it as minimal as possible).
-- @jfmeys in #5

  • Test all judges
    • anaconda3
    • bash
    • biopythia
    • haskell
    • java
    • nodejs
    • prolog
    • scratch

Original pull request by @beardhatcode on Thu Apr 05 2018 at 22:53.

@ninewise
Copy link

ninewise commented Aug 1, 2019

Haskell judge still works, but it doesn't have the logger script (the $(()) syntax is not POSIX iirc)

Original comment by @ninewise on Fri Apr 06 2018 at 09:52.

@ninewise
Copy link

ninewise commented Aug 1, 2019

Alpine uses busybox though, which also supports $(()), so everything should™ work.

Original comment by @ninewise on Fri Apr 06 2018 at 09:56.

@ninewise
Copy link

ninewise commented Aug 1, 2019

Java judge still works.

Original comment by @ninewise on Fri Apr 06 2018 at 10:03.

@beardhatcode
Copy link
Member Author

Prolog judge also still works

Original comment by @beardhatcode on Mon Apr 09 2018 at 14:48.

@ninewise ninewise closed this in #22 Aug 9, 2019
@ninewise ninewise deleted the fix/bash-sh branch September 27, 2019 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants