Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add natural translation for DSL #574
base: master
Are you sure you want to change the base?
Add natural translation for DSL #574
Changes from 6 commits
d1a544b
d0cf7de
0334e1f
c1114bc
c61b563
145deae
e14c758
65fb097
e941ef6
eef397b
30bcdcc
4230003
1ddef15
5dabc80
69a77d3
eb62f92
6e258cf
1db1db2
4dedd8c
b9786c2
c63e391
a35c49a
10b0eb3
3539227
e1180f9
466ec16
49079a0
4174beb
1a79a82
81ce161
64a00cd
88a2ede
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I must say I expected this file to be much simpler.
In principle the
!natural_language
should simply be replaced by the content of the specified language in the map.So in my mind, this code should not know whether it is working within a tab, context, testcase,...
The fact that this preprocess script is so heavily linked to the precise TESTed DSL, will make it harder to maintain in the future. Any change to the TESTed DSL will also have to be verified here.
Do you think it is possible to write a more abstract solution, or have I missed some potential issues?
Check warning on line 52 in tested/nat_translation.py
Codecov / codecov/patch
tested/nat_translation.py#L50-L52
Check warning on line 147 in tested/nat_translation.py
Codecov / codecov/patch
tested/nat_translation.py#L147
Check warning on line 150 in tested/nat_translation.py
Codecov / codecov/patch
tested/nat_translation.py#L149-L150
Check warning on line 155 in tested/nat_translation.py
Codecov / codecov/patch
tested/nat_translation.py#L153-L155
Check warning on line 187 in tested/nat_translation.py
Codecov / codecov/patch
tested/nat_translation.py#L186-L187
Check warning on line 189 in tested/nat_translation.py
Codecov / codecov/patch
tested/nat_translation.py#L189