fix favorite icon update (closes #477)

doerfli · Jun 15, 2024 · 693b27d · 693b27d
1 parent 8291d33
commit 693b27d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/app/javascript/controllers/recipe_controller.js b/app/javascript/controllers/recipe_controller.js
@@ -3,8 +3,9 @@ import { Utils } from "../src/utils"
 
 export default class extends Controller {
   static targets = ["deleteButtons", 
-    "imagelg", "imagebox", "imagefulllink"
-  ]
+    "imagelg", "imagebox", "imagefulllink",
+    "favoriteicon",
+  ];
 
   delete() {
     var url = this.data.get("url");
@@ -46,9 +47,11 @@ export default class extends Controller {
       },
     }).then(function json(response) {
       return response.json()
-    }).then(function(data) {
-      Turbolinks.visit(data.redirect_url);
     });
+    // toggle heart icon
+    var favoriteIcon = this.favoriteiconTarget;
+    favoriteIcon.classList.toggle("far");
+    favoriteIcon.classList.toggle("fas");
   }
 
   imageLgShow(event) {

diff --git a/app/views/recipes/show.html.erb b/app/views/recipes/show.html.erb
@@ -81,9 +81,9 @@
   <div class="bottomactions">
     <button class="button" data-action="click->recipe#favorite">
       <% if @recipe.favorite %> 
-        <i class="fas fa-heart"></i>
+        <i class="fas fa-heart" data-recipe-target="favoriteicon"></i>
       <% else %>
-        <i class="far fa-heart"></i>
+        <i class="far fa-heart" data-recipe-target="favoriteicon"></i>
       <% end %>
     </button>
     <a  href="<%= edit_recipe_path @recipe %>">