Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Keyboard layout #12

Merged
merged 2 commits into from
Sep 22, 2024
Merged

[Feature] Keyboard layout #12

merged 2 commits into from
Sep 22, 2024

Conversation

dogo
Copy link
Owner

@dogo dogo commented Sep 22, 2024

Fixes issue #.
  • This pull request follows the coding standards
This PR changes:
  • Add support to KeyboardLayoutGuide

@dogo dogo changed the title Feauture/keyboard layout [Feauture] Keyboard layout Sep 22, 2024
@dogo dogo changed the title [Feauture] Keyboard layout [Feature] Keyboard layout Sep 22, 2024
Copy link

1 Warning
⚠️ Big PR

SwiftLint found issues

Warnings

File Line Reason
KeyboardLayoutGuide+Mirror.swift 16 Force unwrapping should be avoided (force_unwrapping)
KeyboardLayoutGuideTests.swift 14 Implicitly unwrapped optionals should be avoided when possible (implicitly_unwrapped_optional)
KeyboardLayoutGuideTests.swift 15 Implicitly unwrapped optionals should be avoided when possible (implicitly_unwrapped_optional)
KeyboardLayoutGuideTests.swift 37 Line should be 120 characters or less; currently it has 123 characters (line_length)
KeyboardLayoutGuideTests.swift 48 Line should be 120 characters or less; currently it has 145 characters (line_length)
KeyboardLayoutGuideTests.swift 49 Line should be 120 characters or less; currently it has 151 characters (line_length)
KeyboardLayoutGuideTests.swift 69 Line should be 120 characters or less; currently it has 164 characters (line_length)
KeyboardLayoutGuideTests.swift 71 Line should be 120 characters or less; currently it has 152 characters (line_length)
KeyboardLayoutGuideTests.swift 81 Line should be 120 characters or less; currently it has 138 characters (line_length)
KeyboardLayoutGuideTests.swift 83 Line should be 120 characters or less; currently it has 127 characters (line_length)

Generated by 🚫 Danger

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

Attention: Patch coverage is 84.32836% with 21 lines in your changes missing coverage. Please review.

Project coverage is 92.17%. Comparing base (7252ccf) to head (4fe61d3).
Report is 35 commits behind head on develop.

Files with missing lines Patch % Lines
Sources/SketchKit/SketchKitDSL.swift 0.00% 12 Missing ⚠️
Sources/SketchKit/KeyboardLayoutGuide.swift 89.55% 7 Missing ⚠️
Sources/SketchKit/Constrainable.swift 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #12      +/-   ##
===========================================
- Coverage    92.85%   92.17%   -0.68%     
===========================================
  Files           33       37       +4     
  Lines         1539     1674     +135     
===========================================
+ Hits          1429     1543     +114     
- Misses         110      131      +21     
Files with missing lines Coverage Δ
...ts/Helpers/Mirror/KeyboardLayoutGuide+Mirror.swift 100.00% <100.00%> (ø)
...Tests/Helpers/TestExtensions/Mirror+Testable.swift 100.00% <100.00%> (ø)
...ests/SketchKitTests/KeyboardLayoutGuideTests.swift 100.00% <100.00%> (ø)
Sources/SketchKit/Constrainable.swift 66.66% <0.00%> (-33.34%) ⬇️
Sources/SketchKit/KeyboardLayoutGuide.swift 89.55% <89.55%> (ø)
Sources/SketchKit/SketchKitDSL.swift 33.33% <0.00%> (-66.67%) ⬇️

@dogo dogo merged commit d37428c into develop Sep 22, 2024
3 of 4 checks passed
@dogo dogo deleted the feauture/keyboardLayout branch September 22, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant